Re: [Xen-devel] [PATCH] x86/HVM: make hvm_find_io_handler() static

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 01 February 2017 11:24
> To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Paul Durrant
> <Paul.Durrant@xxxxxxxxxx>
> Subject: [PATCH] x86/HVM: make hvm_find_io_handler() static
> 
> This reduces the chance of misuse - calling it must in particular
> always be accompanied by calling the corresponding ->complete() hook.
> Constify its parameter at once.

Indeed. No good reason this is not already static AFACT.

> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> 
> --- a/xen/arch/x86/hvm/intercept.c
> +++ b/xen/arch/x86/hvm/intercept.c
> @@ -210,7 +210,7 @@ int hvm_process_io_intercept(const struc
>      return rc;
>  }
> 
> -const struct hvm_io_handler *hvm_find_io_handler(ioreq_t *p)
> +static const struct hvm_io_handler *hvm_find_io_handler(const ioreq_t
> *p)
>  {
>      struct domain *curr_d = current->domain;
>      unsigned int i;
> --- a/xen/include/asm-x86/hvm/io.h
> +++ b/xen/include/asm-x86/hvm/io.h
> @@ -97,8 +97,6 @@ struct hvm_io_ops {
>  int hvm_process_io_intercept(const struct hvm_io_handler *handler,
>                               ioreq_t *p);
> 
> -const struct hvm_io_handler *hvm_find_io_handler(ioreq_t *p);
> -
>  int hvm_io_intercept(ioreq_t *p);
> 
>  struct hvm_io_handler *hvm_next_io_handler(struct domain *d);
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel