Re: [Xen-devel] [PATCH] VT-d/RMRR: Adjust the return values of register_one_rmrr()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.02.17 at 18:51, <venu.busireddy@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -840,13 +841,13 @@ static int __init acpi_parse_dmar(struct 
> acpi_table_header *table)
>                      entry_header->type);
>              break;
>          }
> -        if ( ret )
> +        if ( ret < 0 )
>              break;
>  
>          entry_header = ((void *)entry_header + entry_header->length);
>      }
>  
> -    if ( ret )
> +    if ( ret < 0 )
>      {
>          printk(XENLOG_WARNING
>                 "Failed to parse ACPI DMAR.  Disabling VT-d.\n");
> @@ -856,7 +857,7 @@ static int __init acpi_parse_dmar(struct 
> acpi_table_header *table)
>  out:
>      /* Zap ACPI DMAR signature to prevent dom0 using vt-d HW. */
>      acpi_dmar_zap();
> -    return ret;
> +    return ret < 0 ? ret : 0;
>  }

I think these adjustments are being done too high up the call stack.
Why don't you simply convert a positive return from
register_one_rmrr() to zero in acpi_parse_one_rmrr()?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel