[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xl: Fix segfault on domain reboot

On 02/02/2017 12:25, Wei Liu wrote:
> You didn't check if diskws_new is NULL.
> Actually you can just use xrealloc here.

You're right, using xrealloc is much better here.

> It seems that you've used "xl config-update" to update the domain
> configuration. Is this correct?
> But actually we might want to fix the other code path as well.
> Please give me some time to go over the code path to see if there is a
> better approach than this patch. 

Yes, we use "xl config-update" although the documentation states it
should not be used. We need this in order to update the domain's kernel
before a reboot in our case.

Indeed, there should be a better approach than this. We were aware that
this fix is not very elegant and will be thankful if you can come up
with a better solution.

Fatih ACAR

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.