Re: [Xen-devel] [PATCH 2/2] xl: disable events earlier for shutdown event

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH 2/2] xl: disable events earlier for shutdown event"):
> We need to disable event machinery when the guest shuts down.  It
> doesn't really matter where we disable it as long as it is within the
> branch for shutdown event.

I don't think this is necessary.  My intent was that libxl_ctx_free
would automatically disable all event generation, and that it is
therefore not necessary to call _disable.

This isn't documented particularly clearly, but libxl_event.h says:

  * An evgen is associated with the libxl_ctx used for its creation.
  * After libxl_ctx_free, all corresponding evgen handles become
  * invalid and must no longer be passed to evdisable.

This implies it's legal to call libxl_ctx_free with some events
enabled.

But I think I don't really understand what the original bug is.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel