[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: sched: improve debug dump output.

On Wed, 2017-02-01 at 14:59 +0000, George Dunlap wrote:
> On 26/01/17 16:52, Dario Faggioli wrote:
> > 
> > Scheduling information debug dump for Credit2 is hard
> > to read as it contains the same information repeated
> > multiple time in different ways.
> > 
> > [..]
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Hang on -- how does this relate to the credit2 dumping patch you sent
> the previous week?
Err... Right, I'll tell you how they're related: I basically forgot
that I did send the earlier one! :-(

> I'm all in favor of not saving up a massive queue of patches, but if
> the
> patches have conflicts with existing patches, I think it would be
> better
> if you re-sent a full series with a new version number, so I wouldn't
> have to try to figure out what order they needed to be applied in and
> which ones weren't necessary anymore.  There's no problem, I don't
> think, of sending version n+1 of a series that has no changes other
> than
> adding new patches.
Indeed. But the problem in this case is I lost track of the fact that I
did send the other one, and so I resent, after reworking it a bit more.

Sorry for the confusion, this is totally my fault. :-/

> I've checked in and pushed the three patches that I reviewed today;
> can
> you rebase your outstanding changes and send another series?
Ok, I'll rebase this one on top of current staging and resubmit.

> Thanks!  And sorry it took so long to get to.
Well, sorry for the mess. :-P

Thanks and Regards,
<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.