Re: [Xen-devel] [PATCH v3 01/11] x86emul/test: add missing dependency for x86_emulate.o

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.02.17 at 18:43, <wei.liu2@xxxxxxxxxx> wrote:
> On Wed, Feb 01, 2017 at 06:03:20AM -0700, Jan Beulich wrote:
>> >>> On 01.02.17 at 13:02, <wei.liu2@xxxxxxxxxx> wrote:
>> > --- a/tools/tests/x86_emulator/Makefile
>> > +++ b/tools/tests/x86_emulator/Makefile
>> > @@ -45,7 +45,7 @@ x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h:
>> >  
>> >  HOSTCFLAGS += $(CFLAGS_xeninclude)
>> >  
>> > -x86_emulate.o: x86_emulate.c x86_emulate/x86_emulate.c 
>> > x86_emulate/x86_emulate.h
>> > +x86_emulate.o: x86_emulate.c x86_emulate.h x86_emulate/x86_emulate.c 
>> > x86_emulate/x86_emulate.h
>> >    $(HOSTCC) $(HOSTCFLAGS) -D__XEN_TOOLS__ -c -g -o $@ $<
>> >  
>> >  test_x86_emulator.o: test_x86_emulator.c blowfish.h 
>> > x86_emulate/x86_emulate.h
>> 
>> I think this latter one should be updated too. Which then calls for
>> macroizing:
>> 
>> x86_emulate.h := x86_emulate.h x86_emulate/x86_emulate.h
> 
> Not sure I understand what you want, but using x86_emulate.h as variable
> name looks a bit weird.

Well, that name very clearly identifies what the variable is to
represent. If the dot in the name is really disturbing, I could live
with x86_emulate-h as the name. Your proposed adjustment
looks exactly like I was hoping for.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel