[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/EFI: fix build when using GNU Make 4.1

>>> On 02.02.17 at 23:46, <cardoe@xxxxxxxxxx> wrote:
> Since c/s eee5909e9d (x86/EFI: use less crude a way of generating the
> build ID) builds have been broken when using GNU Make 4.1. This is
> because there are no dependencies on buildid.o and as such GNU Make does
> not build it. This adds a dependency so that it is built.

While I trust you to see an actual problem, I can't follow this

> --- a/xen/arch/x86/efi/Makefile
> +++ b/xen/arch/x86/efi/Makefile
> @@ -14,5 +14,7 @@ extra-$(efi) += boot.init.o relocs-dummy.o runtime.o 
> compat.o buildid.o
>  %.o: %.ihex
>       $(OBJCOPY) -I ihex -O binary $< $@
> +boot.init.o: buildid.o
> +
>  stub.o: $(extra-y)

Here we see a dependency of stub.o on $(extra-y), and in the hunk
header we see that extra-y includes buildid.o. And if a proper
dependency was missing, I wouldn't be able to tell why things work
with older make, nor would I understand why it fails for you but not
for me with 4.1. So there must be something more to this. Is it
perhaps really Daniel's patch 2, up to v13 of which introduced this
problem (in which case it should really be fixed there, instead of by
a standalone change)?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.