Re: [Xen-devel] [PATCH] xen/common: Replace __FUNCTION__ with __func__

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 3 Feb 2017, Andrew Cooper wrote:
> __func__ is standard C99, whereas __FUNCTION__ is a GCCism.
> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> CC: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/common/grant_table.c          | 4 ++--
>  xen/common/libelf/libelf-loader.c | 4 ++--
>  xen/common/wait.c                 | 2 +-
>  xen/include/acpi/platform/acgcc.h | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> index a425a9e..04058dd 100644
> --- a/xen/common/grant_table.c
> +++ b/xen/common/grant_table.c
> @@ -3547,10 +3547,10 @@ static void gnttab_usage_print(struct domain *rd)
>  static void gnttab_usage_print_all(unsigned char key)
>  {
>      struct domain *d;
> -    printk("%s [ key '%c' pressed\n", __FUNCTION__, key);
> +    printk("%s [ key '%c' pressed\n", __func__, key);
>      for_each_domain ( d )
>          gnttab_usage_print(d);
> -    printk("%s ] done\n", __FUNCTION__);
> +    printk("%s ] done\n", __func__);
>  }
>  
>  static int __init gnttab_usage_init(void)
> diff --git a/xen/common/libelf/libelf-loader.c 
> b/xen/common/libelf/libelf-loader.c
> index a72cd8a..1644f16 100644
> --- a/xen/common/libelf/libelf-loader.c
> +++ b/xen/common/libelf/libelf-loader.c
> @@ -536,12 +536,12 @@ uint64_t elf_lookup_addr(struct elf_binary * elf, const 
> char *symbol)
>      sym = elf_sym_by_name(elf, symbol);
>      if ( !ELF_HANDLE_VALID(sym) )
>      {
> -        elf_err(elf, "%s: not found: %s\n", __FUNCTION__, symbol);
> +        elf_err(elf, "%s: not found: %s\n", __func__, symbol);
>          return -1;
>      }
>  
>      value = elf_uval(elf, sym, st_value);
> -    elf_msg(elf, "%s: symbol \"%s\" at 0x%" PRIx64 "\n", __FUNCTION__,
> +    elf_msg(elf, "%s: symbol \"%s\" at 0x%" PRIx64 "\n", __func__,
>              symbol, value);
>      return value;
>  }
> diff --git a/xen/common/wait.c b/xen/common/wait.c
> index 4ac98c0..89cfc06 100644
> --- a/xen/common/wait.c
> +++ b/xen/common/wait.c
> @@ -155,7 +155,7 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv)
>  
>      if ( unlikely(wqv->esp == 0) )
>      {
> -        gdprintk(XENLOG_ERR, "Stack too large in %s\n", __FUNCTION__);
> +        gdprintk(XENLOG_ERR, "Stack too large in %s\n", __func__);
>          domain_crash_synchronous();
>      }
>  
> diff --git a/xen/include/acpi/platform/acgcc.h 
> b/xen/include/acpi/platform/acgcc.h
> index 3bb5049..b355e98 100644
> --- a/xen/include/acpi/platform/acgcc.h
> +++ b/xen/include/acpi/platform/acgcc.h
> @@ -46,7 +46,7 @@
>  
>  /* Function name is used for debug output. Non-ANSI, compiler-dependent */
>  
> -#define ACPI_GET_FUNCTION_NAME          __FUNCTION__
> +#define ACPI_GET_FUNCTION_NAME          __func__
>  
>  /*
>   * This macro is used to tag functions as "printf-like" because
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel