[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC 3/6] COLO-Proxy: Setup userspace colo-proxy on secondary side
On Mon, Feb 06, 2017 at 05:27:43PM +0800, Zhang Chen wrote: [...] > > > > > > set_disk_colo_restore(d_config); > > > } else { > > > unset_disk_colo_restore(d_config); > > > } > > > return do_domain_create(ctx, d_config, domid, restore_fd, > > > send_back_fd, > > > - params, colo_proxy_script, ao_how, > > > aop_console_how); > > > + params, colo_proxy_script, > > > userspace_colo_proxy, > > > + ao_how, aop_console_how); > > > } > > > int libxl_domain_soft_reset(libxl_ctx *ctx, > > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > > > index 1bd2057..89c2c9d 100644 > > > --- a/tools/libxl/libxl_types.idl > > > +++ b/tools/libxl/libxl_types.idl > > > @@ -390,6 +390,7 @@ libxl_domain_restore_params = > > > Struct("domain_restore_params", [ > > > ("checkpointed_stream", integer), > > > ("stream_version", uint32, {'init_val': '1'}), > > > ("colo_proxy_script", string), > > > + ("userspace_colo_proxy", libxl_defbool), > > I suppose you can use LIBXL_HAVE_COLO_USERSPACE_PROXY for this whole > > series. > > If I understand correctly, we use LIBXL_HAVE_COLO_USERSPACE_PROXY for > this whole series means we make colo userspace proxy as default option, > User can't use colo kernel proxy by a easy way (remus commands). > The goal of this series is to provide a another way to run colo proxy(we > recommended), > We want to keep the colo kernel proxy function currently(maybe someone can > maintain it), and when colo userspace proxy performance better than kernel > proxy, > we will change colo userspace as default option. > No, that macro is not used to denote which mechanism is the default one. It is used to indicate the availability of a particular thing in libxl. So you can have that macro and choose whichever you want to be the default. Feel free to ask questions if I'm not clear enough. Wei. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |