Re: [Xen-devel] [PATCH v2 0/4] x86/vvmx: correctly emulate VMREAD and VMWRITE

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/02/17 14:57, Sergey Dyasli wrote:
> Currently, emulation of vmread and vmwrite for a guest leads to BUG()
> in cases when actual VMREAD or VMWRITE ends up in VMfail due to invalid
> arguments.  The goal of this patch series is to prevent the BUG() from
> happening and report any kind of VMfail back to the guest, just like
> it would be done by H/W.
>
> v1 --> v2:
> * Removed "ASM_FLAG_OUT" from tools/tests/x86_emulator/x86_emulate.h
> * Replaced "~0UL" with "~0" for VMX_INSN_FAIL_INVALID
> * Removed double underscore prefix from vmwrite_safe() and vmread_safe()
> * Replaced "setb --> setc" and "sete --> setz"
> * Removed "fail_" prefix from "invalid" and "valid" asm constraints
> * Added "\t" to asm
> * Added unlikely() for checking fail conditions
> * Moved "ASM_FLAG_OUT" from lib.h to asm_defns.h
>
> Sergey Dyasli (4):
>   x86/vmx: introduce vmwrite_safe()
>   x86/vmx: improve vmread_safe()
>   x86/vvmx: correctly emulate VMWRITE
>   x86/vvmx: correctly emulate VMREAD

All 4 Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

>
>  xen/arch/x86/hvm/vmx/vmcs.c        | 20 +++++++----
>  xen/arch/x86/hvm/vmx/vvmx.c        | 46 +++++++++++++++++++-----
>  xen/include/asm-x86/asm_defns.h    |  6 ++++
>  xen/include/asm-x86/hvm/vmx/vmcs.h |  6 ++--
>  xen/include/asm-x86/hvm/vmx/vmx.h  | 72 
> +++++++++++++++++++++++++-------------
>  xen/include/asm-x86/hvm/vmx/vvmx.h | 11 ++++--
>  6 files changed, 117 insertions(+), 44 deletions(-)
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel