[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH] standalone-reset: use mkdir -p



Wei Liu writes ("Re: [OSSTEST PATCH] standalone-reset: use mkdir -p"):
> tftptmp=`getconfig TftpTmpDir`
> ensure_dir "$tftp$tftptmp"

OK.  I'm afraid I think if TftpTmpDir's parent does not exist, osstest
should not create it automatically.

> And $tftp is set to /tmp/ in my standalone config.

As an aside: this habit of using /tmp as a personal playground is a
really bad one.

It may be fine on your single-user workstation, but if it slips into
any code or config which you ship to anyone else, it is a security
problem.

You should probably create a ~/tmp.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.