Re: [Xen-devel] [PATCH 1/1] xen/arm: Add pl011 uart support in Xen for guest domains

[Julien Grall <julien.grall@xxxxxxx>]

Hi Bhupinder,

Thank you for the patch.

On 06/02/17 18:09, Bhupinder Thakur wrote:
> As per "VM System Specification for  ARM Processors", there is a requirement 
> for Xen to support guest console
> over pl011 UART, which is SBSA compliant. The changes in this patch implement 
> the pl011 emulation in Xen
> and a new pl011 console support in xenconsoled.
>
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>
> ---
>  tools/console/daemon/io.c       | 170 ++++++++++++++---
>  tools/console/daemon/main.c     |  10 +
>  tools/libxc/include/xc_dom.h    |   3 +
>  tools/libxc/xc_dom_arm.c        |   7 +-
>  tools/libxc/xc_dom_boot.c       |   3 +
>  tools/libxc/xc_domain.c         |   3 -
>  tools/libxl/libxl.c             |   4 +
>  tools/libxl/libxl_arm.c         |  50 ++++-
>  tools/libxl/libxl_dom.c         |   9 +-
>  tools/libxl/libxl_internal.h    |   2 +
>  xen/arch/arm/Makefile           |   1 +
>  xen/arch/arm/domain.c           |   7 +
>  xen/arch/arm/hvm.c              |  22 ++-
>  xen/arch/arm/setup.c            |   1 +
>  xen/arch/arm/vgic.c             |   7 +
>  xen/arch/arm/vpl011.c           | 391 ++++++++++++++++++++++++++++++++++++++++
>  xen/common/event_channel.c      |  11 +-
>  xen/include/asm-arm/domain.h    |  14 ++
>  xen/include/public/arch-arm.h   |   5 +
>  xen/include/public/hvm/params.h |  10 +-
>  xen/include/xen/vpl011.h        | 146 +++++++++++++++
>  21 files changed, 832 insertions(+), 44 deletions(-)
A such big patch should be broke down in multiple small patches to ease 
the review. I will wait the next version before doing any review.
I would recommend to read on Xen wiki the following page:
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches

It will give you advice on how to prepare a patch series.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel