Re: [Xen-devel] [PATCH v2 2/2] xen/kbdif: add multi-touch support

[Oleksandr Andrushchenko <andr2000@xxxxxxxxx>]

On 02/07/2017 08:48 PM, Konrad Rzeszutek Wilk wrote:
> On Thu, Jan 26, 2017 at 09:46:47AM +0200, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> Usually you say a bit in the description of what it does and
> what's its usage is.
>
> Like:
>
> "Multi-touch fields re-use the page that is used by the other features
> which means that you can interleave multi-touch, motion, and key
> events."
>
> Along with:
>
> ---
> v2: Added 'mt' in front of XenBus entries
>      Dropped 'mtouch' subdirectory.
> .. etc.
sure
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> > ---
> >   xen/include/public/io/kbdif.h | 210 ++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 210 insertions(+)
> >
> > diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> > index 446aed2478b5..74883267d6e6 100644
> > --- a/xen/include/public/io/kbdif.h
> > +++ b/xen/include/public/io/kbdif.h
> > @@ -57,6 +57,12 @@
> >    *      Backends, which support reporting of absolute coordinates for pointer
> >    *      device should set this to 1.
> >    *
> > + * feature-multi-touch
> > + *      Values:         <uint>
> > + *
> > + *      Backends, which support reporting of multi-touch events
> > + *      should set this to 1.
> > + *
> >    *------------------------- Pointer Device Parameters ------------------------
> >    *
> >    * width
> > @@ -87,6 +93,11 @@
> >    *      Request backend to report absolute pointer coordinates
> >    *      (XENKBD_TYPE_POS) instead of relative ones (XENKBD_TYPE_MOTION).
> >    *
> > + * request-multi-touch
> > + *      Values:         <uint>
> > + *
> > + *      Request backend to report multi-touch events.
> > + *
> >    *----------------------- Request Transport Parameters -----------------------
> >    *
> >    * event-channel
> > @@ -106,6 +117,25 @@
> >    *
> >    *      OBSOLETE, not recommended for use.
> >    *      PFN of the shared page.
> > + *
> > + *----------------------- Multi-touch Device Parameters -----------------------
> > + *
> > + * mt-num-contacts
> s/mt/multi-touch/ please for all of the entries.
Namely:
mt-num-contacts -> multi-touch-num-contacts
mt-width -> multi-touch-width
mt-height -> multi-touch-height
> > + *      Values:         <uint>
> > + *
> > + *      Number of simultaneous touches reported.
> > + *
> > + * mt-width
> > + *      Values:         <uint>
> > + *
> > + *      Width of the touch area to be used by the frontend
> > + *      while reporting input events, pixels, [0; UINT32_MAX].
> > + *
> > + * mt-height
> > + *      Values:         <uint>
> > + *
> > + *      Height of the touch area to be used by the frontend
> > + *      while reporting input events, pixels, [0; UINT32_MAX].
> >    */
> ... And I think that is it!
Thank you

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel