[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] Enabling vm_event for a guest with more VCPUs than available ring buffer slots freezes the virtual machine
On Tue, Feb 7, 2017 at 1:41 PM, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx> wrote:
On 02/07/2017 10:20 PM, Tamas K Lengyel wrote:
No, not increasing the ring buffer but fixing the check to unblock when there is at least 1 spot on the ring. So look at this comment...
* vm_event_wake_blocked() will wakeup vcpus waiting for room in the
* ring. These vCPUs were paused on their way out after placing an event,
* but need to be resumed where the ring is capable of processing at least
* one event from them.
.. it seems to me that the check "online >= avail_req" was just wrong from the start.
Good, that's what I expected. There really is no point in blocking a vCPU that is already paused. But I would just add that check to the if above as another && clause.
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
Lists.xenproject.org is hosted with RackSpace, monitoring our