Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: Tuesday, February 07, 2017 6:05 PM
> 
> On Tue, Feb 07, 2017 at 02:51:54AM -0700, Jan Beulich wrote:
> > >>> On 07.02.17 at 00:32, <chao.gao@xxxxxxxxx> wrote:
> > > Commit c7bdecae42 ("x86/apicv: fix RTC periodic timer and apicv issue") 
> > > has
> > > added a assertion that intack.vector is the highest priority vector. But
> > > according to the osstest, the assertion failed sometimes. More discussion 
> > > can
> > > be found in the thread
> > > (https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg01019.html).
> > >
> > > The assertion failure is hard to reproduce. In order to root cause issue, 
> > > this
> > > patch is to add logs to dump PIR and vIRR when failure takes place. It 
> > > should
> > > be reverted once the root cause is found.
> > >
> > > Signed-off-by: Chao Gao <chao.gao@xxxxxxxxx>
> >
> > If this wasn't just a temporary thing, I'd have some comments, but
> > it's good enough (perhaps with a little massaging when committing)
> > for this purpose.
> >
> > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > Ian, Wei, is there a way to automatically scan osstest logs for
> > occurrences of the extra output, or does someone need to look
> > through the logs of every spurious failure?
> >
> 
> I don't think there is automatically scanning in place.

Curious how this issue was initially caught? Would same practice make
sure next fail catching our eye?

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel