Re: [Xen-devel] [PATCH] x86/mm: Alter is_xen_fixed_mfn() to use mfn_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.02.17 at 19:57, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/mm.h
> +++ b/xen/include/xen/mm.h
> @@ -599,4 +599,10 @@ static inline void filtered_flush_tlb_mask(uint32_t 
> tlbflush_timestamp)
>      }
>  }
>  
> +static inline bool is_xen_fixed_mfn(mfn_t mfn)
> +{
> +    return (pfn_to_paddr(mfn_x(mfn)) >= __pa(&_start) &&
> +            pfn_to_paddr(mfn_x(mfn)) <= __pa(&_end));
> +}

Even if you only morph what's been there before, I do think the
latter wants to be < instead of <= . With that adjusted
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
but I'm also unconvinced it wouldn't be better to compare PFNs
instead of physical addresses here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel