Re: [Xen-devel] [PATCH] xenbus: Neaten xenbus_va_dev_error

[Joe Perches <joe@xxxxxxxxxxx>]

On Wed, 2017-02-08 at 10:33 -0500, Boris Ostrovsky wrote:
> On 02/08/2017 06:33 AM, Joe Perches wrote:
> > This function error patch can be simplified, so do so.
> > 
> > Remove fail: label and somewhat obfuscating, used once "error_path"
> > function.

btw: I left it alone, but likely

#define PRINTF_BUFFER_SIZE 4096

is probably excessive as the maximum printk
buffer is 1024.

The xenbus_write might be longer though so
maybe it's OK to use 4096, but there is some
inequivalence there.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel