Re: [Xen-devel] [PATCH 2/8] xen/arm: acpi: Rework acpi_boot_table_init error paths

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 03/02/17 20:44, Andrew Cooper wrote:
> On 03/02/17 19:18, Julien Grall wrote:
> > @@ -260,16 +257,22 @@ int __init acpi_boot_table_init(void)
> >      error = acpi_table_init();
> >      if ( error )
> >      {
> > -        disable_acpi();
> > -        return error;
> > +        printk("%s: Unable to initialize table parser (%d)\n",
> > +               __FUNCTION__, error);
> As a nit, please use __func__.
>
> It is standard C, whereas __FUNCTION__ is a GCCism.
>
> (On that note, there are very few remaining uses in the hypervisor - let
> me submit a patch killing the remaining uses.)
I will fix it and try to remember for next time.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel