[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: Fix ARM build following c/s 11c397c

On 08/02/2017 19:24, Julien Grall wrote:
> On 08/02/17 19:21, Andrew Cooper wrote:
>> On 08/02/17 19:13, Julien Grall wrote:
>>> Hi Andrew,
>>> On 08/02/17 19:10, Andrew Cooper wrote:
>>>> c/s 11c397c broke the ARM build by introducing a common ACCESS_ONCE()
>>>> which is
>>>> different to the definiton in smmu.c
> Forgot this one s/definiton/definition/
>>>> The SMMU code included a scalar typecheck, which is worth keeping
>>>> in the
>>>> common case, given ACCESS_ONCE()'s restrictions.  However, express the
>>>> typecheck differently so as to avoid Coverity compliants about unused
>>> s/compliants/complaint/
>> In this case, it is multiple individual complains about unused
>> individual variables, so "complaints" is scans perfectly well.
>> An alternative would be "to avoid Coverity complaining about..." if you
>> prefer?
> Sorry I was flagging the typo "i" and "a" inverted and not the plural.

Ah, sorry.  I hadn't even spotted that.

Will fix both.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.