Re: [Xen-devel] [PATCH v2 00/12] libxl: split up libxl.c

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Feb 09, 2017 at 10:30:13AM +0100, Juergen Gross wrote:
> libxl.c has become rather large. Split it up into multiple files.
> 
> Changes are:
> - modification of Copyright comment (patch 1)
> - made two functions non-static: libxl__get_memory_target(),
>   xcinfo2xlinfo() (patch 2)
> - white space cleanup of libxl.c (patch 3)
> - moving functions into new or existing sources (patches 4-11):
>   just code movement, no functional changes besides needed Makefile
>   adjustments for new sources
> - made one function static: libxl__device_frontend_path() (patch 12)
> 
> Changes in V2:
> - address comments of Ian Jackson: add new patches 1-3, 12
> 
> Juergen Gross (12):
>   libxl: adjust copyright comment of libxl.c
>   libxl: make some functions global to prepare splitting up libxl.c
>   libxl: white space cleanup
>   libxl: carve out cpupool specific functions from libxl.c
>   libxl: carve out scheduler specific functions from libxl.c
>   libxl: carve out disk specific functions from libxl.c
>   libxl: carve out console specific functions from libxl.c
>   libxl: carve out memory specific functions from libxl.c
>   libxl: move device specific functions out of libxl.c
>   libxl: carve out tmem specific functions from libxl.c
>   libxl: carve out domain specific functions from libxl.c
>   libxl: make one function static
> 

Series:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I'm a bit two-minded about the last patch, though.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel