Re: [Xen-devel] [PATCH v2 02/12] libxl: make some functions global to prepare splitting up libxl.c

[Juergen Gross <jgross@xxxxxxxx>]

On 09/02/17 12:36, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH v2 02/12] libxl: make some functions global to 
> prepare splitting up libxl.c"):
>> Splitting up libxl.c will require two functions to be globally visible.
>> Add their prototypes to libxl_internal.h.
> 
> Thanks.  However,
> 
>> -static void xcinfo2xlinfo(libxl_ctx *ctx,
>> -                          const xc_domaininfo_t *xcinfo,
>> -                          libxl_dominfo *xlinfo)
>> +void xcinfo2xlinfo(libxl_ctx *ctx,
>> +                   const xc_domaininfo_t *xcinfo,
>> +                   libxl_dominfo *xlinfo)
> 
> This function needs a libxl__ prefix adding to its name.

Aah, of course!

Will send V3 after waiting for more comments for a while...


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel