Re: [Xen-devel] [PATCH] x86/vmx: fix build with clang 3.8.0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.02.17 at 13:49, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 09/02/17 11:33, Roger Pau Monne wrote:
>> --- a/xen/include/asm-x86/hvm/vmx/vmx.h
>> +++ b/xen/include/asm-x86/hvm/vmx/vmx.h
>> @@ -602,15 +602,16 @@ void vmx_pi_hooks_assign(struct domain *d);
>>  void vmx_pi_hooks_deassign(struct domain *d);
>>  
>>  /* EPT violation qualifications definitions */
>> -typedef union __transparent__ ept_qual {
>> +typedef union ept_qual {
> 
> Please can we use
> 
> typedef __transparent__ union ept_qual {
> 
> which clang is happy with, and will help avoid problems such as the
> cper_mce_record issue in c/s f8be76e2fe

Would clang also be happy with it moved near the end of that
line

typedef union ept_qual __transparent__ {

Having the attribute ahead of "union" is, I think, strictly speaking
undefined behavior, as it then may as well apply to "typedef".

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel