[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH v1 03/21] NUMA: Move arch specific NUMA code as common

>>> On 09.02.17 at 16:56, <vijay.kilari@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -25,7 +25,7 @@ static struct acpi_table_slit *__read_mostly acpi_slit;
>  static nodemask_t memory_nodes_parsed __initdata;
>  static nodemask_t processor_nodes_parsed __initdata;
> -static struct node nodes[MAX_NUMNODES] __initdata;
> +extern struct node nodes[MAX_NUMNODES] __initdata;

NAK to changes like this. Declarations belong in header files and
shouldn't have __init* annotations. But along the line of what I've
said for patch 2, it would be better if this wasn't made non-static.

> +__init int conflicting_memblks(u64 start, u64 end)

As you're moving code, again please sanitize stuff: Here, the __init
annotation is misplaced (it conventionally goes between type and
name). And of course the name is too generic to be kept as is.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.