Re: [Xen-devel] [PATCH] x86/bitops: Force __scanbit() to be always inline

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.02.17 at 12:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> It turns out that GCCs 4.9.2 and 6.3.0 instantiate __scanbit() in three
> translation units, but never references the result.  All real uses of
> __scanbit() are already suitably inline.

While I'm not opposed to this at all, we should set ourselves a
reasonably clear rule of thumb of when to use always_inline. As
was noted the other day, mixing (apparently arbitrarily) with
normal inline functions is at least confusing to the reader. For
that it may be necessary to understand what exactly it is that
makes gcc create (even unreferenced) static function instances.

Jan

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel