[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 02/11] x86emul: flatten twobyte_table[]

On 01/02/17 11:13, Jan Beulich wrote:
> +static const struct {
> +    opcode_desc_t desc;
> +} twobyte_table[256] = {
> +    [0x00] = { ModRM },

This is definitely an improvement in readability, so Acked-by: Andrew
Cooper <andrew.cooper3@xxxxxxxxxx> (I have briefly checked that
everything appears to be the same, but not checked thoroughly)

I had a plan to do this anyway, including the onebyte table, and adding
instruction/group comments like the case statements for emulation.  Is
that something you can introduce in your series, or shall I wait and
retrofit a patch later?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.