[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] xen/grants: print grant number and handle in hex format

On 13/02/17 15:17, Roger Pau Monne wrote:
> On Mon, Feb 13, 2017 at 02:40:00PM +0000, Andrew Cooper wrote:
>> On 13/02/17 14:34, Roger Pau Monne wrote:
>>> @@ -1706,7 +1706,7 @@ gnttab_prepare_for_transfer(
>>>      if ( unlikely(ref >= nr_grant_entries(rgt)) )
>>>      {
>>>          gdprintk(XENLOG_INFO,
>>> -                "Bad grant reference (%d) for transfer to domain(%d).\n",
>>> +                "Bad grant reference (%#x) for transfer to domain(%d).\n",
>>>                  ref, rd->domain_id);
>> We can shorten this to just d%d, matching our prevailing domain notation.
> OK, so now it's: "Bad grant reference (%#x) for transfer to d%d\n"

TBH, I'd also drop the brackets here.  They don't add anything but
length to the message.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.