Re: [Xen-devel] [PATCH] ACPICA: ACPI 6.0: Add support for IORT table.

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 15 Feb 2017, Sameer Goel wrote:
> From: Lv Zheng <lv.zheng@xxxxxxxxx>
> 
> ACPICA commit 5de82757aef5d6163e37064033aacbce193abbca
> 
> This patch adds support for IORT (IO Remapping Table) in iasl.
> 
> Note that some field names are modified to shrink their length or the
> decompiled IORT ASL will contain fields with ugly ":" alignment.
> 
> The IORT contains field definitions around "Memory Access Properties". This
> patch also adds support to encode/decode it using inline table.
> 
> This patch doesn't add inline table support for the SMMU interrupt fields
> due to a limitation in current ACPICA data table support. Lv Zheng.
> 
> Link: https://github.com/acpica/acpica/commit/5de82757
> Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> [Linux commit 874f6a723e56d0da9e481629b17482bcd3801ecf]
> [only port the IORT changes]
> Signed-off-by: Sameer Goel <sgoel@xxxxxxxxxxxxxx>

if this is a straight port from linux, then please don't make other
changes on top of it such as:


> @@ -5,7 +5,7 @@
>   
> *****************************************************************************/
>  
>  /*
> - * Copyright (C) 2000 - 2011, Intel Corp.
> + * Copyright (C) 2000 - 2016, Intel Corp.
>   * All rights reserved.
>   *
>   * Redistribution and use in source and binary forms, with or without
> @@ -67,7 +67,8 @@
>  #define ACPI_SIG_DBGP           "DBGP"       /* Debug Port table */
>  #define ACPI_SIG_DMAR           "DMAR"       /* DMA Remapping table */
>  #define ACPI_SIG_HPET           "HPET"       /* High Precision Event Timer 
> table */
> -#define ACPI_SIG_IBFT           "IBFT"       /* i_sCSI Boot Firmware Table */
> +#define ACPI_SIG_IBFT           "IBFT"       /* iSCSI Boot Firmware Table */

[...]

> +enum acpi_iort_node_type {
> +     ACPI_IORT_NODE_ITS_GROUP = 0x00,
> +     ACPI_IORT_NODE_NAMED_COMPONENT = 0x01,
> +     ACPI_IORT_NODE_PCI_ROOT_COMPLEX = 0x02,
> +     ACPI_IORT_NODE_SMMU = 0x03,
> +     ACPI_IORT_NODE_SMMU_V3 = 0x04

SMMU_V3 wasn't present in 874f6a723e56d0da9e481629b17482bcd3801ecf 


> +struct acpi_iort_smmu_v3 {
> +     u64 base_address;       /* SMMUv3 base address */
> +     u32 flags;
> +     u32 reserved;
> +     u64 vatos_address;
> +     u32 model;              /* O: generic SMMUv3 */
> +     u32 event_gsiv;
> +     u32 pri_gsiv;
> +     u32 gerr_gsiv;
> +     u32 sync_gsiv;
> +};
> +
> +/* Masks for Flags field above */
> +
> +#define ACPI_IORT_SMMU_V3_COHACC_OVERRIDE   (1)
> +#define ACPI_IORT_SMMU_V3_HTTU_OVERRIDE     (1<<1)

Same here.

I think you also need 4ac78baf88d85c49883fcc87d31198ebe408e54d

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel