[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 04/19] xen/mce: remove unused x86_mcinfo_add()

>>> On 17.02.17 at 07:39, <haozhong.zhang@xxxxxxxxx> wrote:
> Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>

Not sure here, I can't imagine the function being here without
reason, even if the plans perhaps never got carried out. Could
you please identify in the commit message here whether there
ever were callers (and if so, when the last one went away) or
what commit introduced the function without any users?

> --- a/xen/arch/x86/cpu/mcheck/mce.h
> +++ b/xen/arch/x86/cpu/mcheck/mce.h
> @@ -146,7 +146,6 @@ typedef struct mcinfo_extended *(*x86_mce_callback_t)
>      (struct mc_info *, uint16_t, uint64_t);
>  extern void x86_mce_callback_register(x86_mce_callback_t);
> -void *x86_mcinfo_add(struct mc_info *mi, void *mcinfo);
>  void *x86_mcinfo_reserve(struct mc_info *mi, int size);
>  void x86_mcinfo_dump(struct mc_info *mi);

There's a comment earlier in this file which would need adjustment
too. Maybe that also helps understand if the function would better
be left in place ...


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.