Re: [Xen-devel] [PATCH 3/4] xenstore: make memory report available via XS_DEBUG

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Feb 21, 2017 at 01:36:58PM +0100, Juergen Gross wrote:
> On 21/02/17 13:16, Wei Liu wrote:
> > On Tue, Feb 21, 2017 at 01:00:58PM +0100, Juergen Gross wrote:
> >> Add a XS_DEBUG command to xenstored for doing a talloc report to a
> >> file. Right now this is supported by specifying a command line option
> >> when starting xenstored and sending a signal to the daemon to trigger
> >> the report.
> >>
> >> To dump the report to the standard log file call:
> >>
> >> xenstore-control memreport
> >>
> >> To dump the report to a new file call:
> >>
> >> xenstore-control memreport <file>
> >>
> > 
> > I think this should be named xenstore-debug to match the wire command name.
> 
> So you think I should rename the already existing program?
> 

Oops. No.

> BTW: I'd rather rename XS_DEBUG to XS_CONTROL (or make that an
> alias to XS_DEBUG), as I think there are more useful ways to
> control xenstore behavior, e.g. by modifying quota (per domain
> or globally).
> 

Yes, this is better.

We should rename XS_DEBUG to XS_CONTROL and then

#define XS_DEBUG XS_CONTROL

in header file.

> 
> Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel