[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 7/7] xen/x86: setup PVHv2 Dom0 ACPI tables



>>> On 10.02.17 at 13:33, <roger.pau@xxxxxxxxxx> wrote:
> Changes since v5:
>  - s/hvm_copy_to_guest_phys_vcpu/hvm_copy_to_guest_phys/.
>  - Move pvh_add_mem_range to previous patch.
>  - Add a comment regarding the current limitation to only 1 emulated IO APIC.
>  - s/dom0_max_vcpus()/max_vcpus/ in pvh_setup_acpi_madt.
>  - Cast structures to void when assigning.
>  - Declare banned_tables with the initconst annotation.
>  - Expand some comments messages.
>  - Initialize the RSDP local variable.
>  - Only provide x2APIC entries in the MADT.

I've just checked the system I had mentioned earlier, and indeed
there's a mixture of x2APIC and LAPIC entries there, but no two
entries for the same CPU / APIC ID. So I guess as long as we're
convinced PVH guests are fine with finding just x2APIC entries we
can keep it that way, and if later we find the need to add LAPIC
entries, we may still do so. Of course this implies that PVH guests
must not assume to only find x2APIC entries. Hence
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.