Re: [Xen-devel] [PATCH v2 2/3] x86/vpmu: Disable VPMU if guest's CPUID indicates no PMU support

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

> I think the code as-is is ok, although it would be nice to extend the
> basic{} union to have a named uint8_t for pmu_version.


Something like this?

diff --git a/xen/include/asm-x86/cpuid.h b/xen/include/asm-x86/cpuid.h
index bc3fc7c..f73ae19 100644
--- a/xen/include/asm-x86/cpuid.h
+++ b/xen/include/asm-x86/cpuid.h
@@ -117,7 +117,15 @@ struct cpuid_policy
             };
 
             /* Leaf 0x2 - TLB/Cache/Prefetch. */
-            uint8_t l2_nr_queries; /* Documented as fixed to 1. */
+            union {
+                uint8_t l2_nr_queries; /* Documented as fixed to 1. */
+                struct cpuid_leaf leaf2;
+            };
+
+            struct cpuid_leaf unused[0xa - 0x3];
+
+            /* Leaf 0xa - Intel PMU. */
+            uint8_t pmu_version;
         };
     } basic;




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel