Re: [Xen-devel] [PATCH 13/19] x86/mce_intel: detect and enable LMCE on Intel host

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.02.17 at 04:16, <haozhong.zhang@xxxxxxxxx> wrote:
> On 02/22/17 08:10 -0700, Jan Beulich wrote:
>> >>> On 17.02.17 at 07:39, <haozhong.zhang@xxxxxxxxx> wrote:
>> > @@ -700,26 +727,31 @@ static void intel_init_mca(struct cpuinfo_x86 *c)
>> >  
>> >      first = mce_firstbank(c);
>> >  
>> > +    if ( !mce_force_broadcast && (msr_content & MCG_LMCE_P) )
>> 
>> Please make all your additions match the prevailing coding style in
>> this file (which admittedly is neither ours nor Linux'es, but a mix).
> 
> The problem is the existing style in this file is not consistent. Both
> if ( cond ) and if (cond) are being used in this file. I chose to use
> Xen style in the new code.

Well, as said - the file isn't cleanly using one style. In such a case,
rather than making a function mixing styles, you should try to
match surrounding code's style (unless you feel up to making a
patch to convert the entire file to uniform style).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel