Re: [Xen-devel] [PATCH 0/2] tools: split xl into a separate directory

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH 0/2] tools: split xl into a separate directory"):
> Basically this needs to be folded into xl/Makefile:
> 
> +# libxenlight should be built before building xl
> +.PHONY: libxl
> +libxl:
> +       $(MAKE) -C $(XEN_ROOT)/tools/libxl
> +$(XL_OBJS): libxl

OMG.

> This is in line with how we do things: libxl/Makefile has something
> similar to build libacpi.
> 
> Please let me know if you have objection to this.

I hadn't noticed that libxl/Makefile had that.

No, this is entirely wrong.  You will end up running make in
tools/libxl twice simultaneously.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel