Re: [Xen-devel] [PATCH v7 2/7] xen/x86: populate PVHv2 Dom0 physical memory map

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/02/17 16:09, Jan Beulich wrote:
>>>> On 23.02.17 at 16:27, <roger.pau@xxxxxxxxxx> wrote:
>> I also don't see much benefit from deviating from what HVM does, so I would
>> just leave it as is.
> Understood. The risk is that in a couple of years time understanding
> why it is the way it is and (whether that's necessary) may take as
> much effort as did the deciphering of the (buggy) hvmloader
> setup code for this.

In which case, just leave a short comment saying something like "Copy
HVMLoader for consistency, not that we expect a PVH domain from using
this for anything other than their AP trampoline".

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel