Re: [Xen-devel] [PATCH 1/3] x86: remove PVHv1 code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.02.17 at 16:32, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 24/02/17 15:13, Roger Pau Monne wrote:
>> diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
>> index 85cbb7c..65b7475 100644
>> --- a/xen/include/public/domctl.h
>> +++ b/xen/include/public/domctl.h
>> @@ -60,11 +60,8 @@ struct xen_domctl_createdomain {
>>   /* Disable out-of-sync shadow page tables? */
>>  #define _XEN_DOMCTL_CDF_oos_off       3
>>  #define XEN_DOMCTL_CDF_oos_off        (1U<<_XEN_DOMCTL_CDF_oos_off)
>> - /* Is this a PVH guest (as opposed to an HVM or PV guest)? */
>> -#define _XEN_DOMCTL_CDF_pvh_guest     4
>> -#define XEN_DOMCTL_CDF_pvh_guest      (1U<<_XEN_DOMCTL_CDF_pvh_guest)
>>   /* Is this a xenstore domain? */
>> -#define _XEN_DOMCTL_CDF_xs_domain     5
>> +#define _XEN_DOMCTL_CDF_xs_domain     4
>>  #define XEN_DOMCTL_CDF_xs_domain      (1U<<_XEN_DOMCTL_CDF_xs_domain)
>>      uint32_t flags;
>>      struct xen_arch_domainconfig config;
>> @@ -97,14 +94,11 @@ struct xen_domctl_getdomaininfo {
>>   /* Being debugged.  */
>>  #define _XEN_DOMINF_debugged  6
>>  #define XEN_DOMINF_debugged   (1U<<_XEN_DOMINF_debugged)
>> -/* domain is PVH */
>> -#define _XEN_DOMINF_pvh_guest 7
>> -#define XEN_DOMINF_pvh_guest  (1U<<_XEN_DOMINF_pvh_guest)
>>  /* domain is a xenstore domain */
>> -#define _XEN_DOMINF_xs_domain 8
>> +#define _XEN_DOMINF_xs_domain 7
>>  #define XEN_DOMINF_xs_domain  (1U<<_XEN_DOMINF_xs_domain)
>>  /* domain has hardware assisted paging */
>> -#define _XEN_DOMINF_hap       9
>> +#define _XEN_DOMINF_hap       8
>>  #define XEN_DOMINF_hap        (1U<<_XEN_DOMINF_hap)
>>   /* XEN_DOMINF_shutdown guest-supplied code.  */
>>  #define XEN_DOMINF_shutdownmask 255
>>
> 
> It would probably be better to leave holes in the bitfield space here,
> given that it is in the public interface.

Or else the domctl interface version would need to be bumped.
Or perhaps it needs to be in any case with such a removal.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel