Re: [Xen-devel] [PATCH v8 10/24] x86: refactor psr: set value: implement cos finding flow.

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-02-26 17:43:20, Wei Liu wrote:
> On Wed, Feb 15, 2017 at 04:49:25PM +0800, Yi Sun wrote:
> > Continue with patch:
> > 'x86: refactor psr: set value: assemble features value array'
> > 
> > We can try to find if there is a COS ID on which all features' COS registers
> > values are same as the array assembled before.
> > 
> > Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> > ---
> >  xen/arch/x86/psr.c | 93 
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 93 insertions(+)
> > 
> > diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
> > index ae108b9..7fab28b 100644
> > --- a/xen/arch/x86/psr.c
> > +++ b/xen/arch/x86/psr.c
> > @@ -145,6 +145,19 @@ struct feat_ops {
> >                         const struct feat_node *feat,
> >                         enum cbm_type type,
> >                         uint64_t m);
> > +    /*
> > +     * compare_val is used in set value process to compare if the
> > +     * input value array can match all the features' COS registers values
> > +     * according to input cos id.
> > +     *
> > +     * The return value is the amount of entries to skip in the value array
> > +     * or error.
> > +     * 1 - one entry in value array.
> > +     * 2 - two entries in value array, e.g. CDP uses two entries.
> > +     * negative - error.
> 
> This doesn't match the code (yet?).
> 
> What about return value 0?
> 
Oh, sorry, per Jan's suggestion, I have change the type of the function. But I
forgot the modify the comments. Will fix it.

> > +     */
> > +    int (*compare_val)(const uint64_t val[], const struct feat_node *feat,
> > +                        unsigned int cos, bool *found);
> 
> Indentation.
> 
Thanks!

> 
> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel