[Xen-devel] [PATCH] x86/PVHv2: fix dereference of native RSDP table mapping

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Check that the RSDP is mapped before trying to access it.

Spotted-by: Coverity
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/domain_build.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c
index d742965..78ae741 100644
--- a/xen/arch/x86/domain_build.c
+++ b/xen/arch/x86/domain_build.c
@@ -2592,6 +2592,11 @@ static int __init pvh_setup_acpi(struct domain *d, 
paddr_t start_info)
 
     /* Craft a custom RSDP. */
     native_rsdp = acpi_os_map_memory(acpi_os_get_root_pointer(), sizeof(rsdp));
+    if ( !native_rsdp )
+    {
+        printk("Failed to map native RSDP\n");
+        return -ENOMEM;
+    }
     memcpy(rsdp.oem_id, native_rsdp->oem_id, sizeof(rsdp.oem_id));
     acpi_os_unmap_memory(native_rsdp, sizeof(rsdp));
     rsdp.xsdt_physical_address = xsdt_paddr;
-- 
2.10.1 (Apple Git-78)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel