[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 6/7] xen/mce: remove ASSERT's about mce_dhandler_num in mce_action()



>>> On 27.02.17 at 06:09, <haozhong.zhang@xxxxxxxxx> wrote:
> The current production build works fine even though those ASSERT's are
> violated.

This - without any evidence - is rather weak an argument. Code
inspection, otoh, pretty clearly tells us the ASSERT()s aren't
needed, as there is no dependency on the asserted expressions
to be true. Therefore, while the change itself is fine, may I ask
for a better commit message?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.