Re: [Xen-devel] [PATCH 1/2] xenstore: free resp in do_control_help

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Mar 01, 2017 at 12:14:14PM +0100, Juergen Gross wrote:
> On 01/03/17 12:07, Wei Liu wrote:
> > Coverity-ID: 1401603
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx> 
> > ---
> >  tools/xenstore/xenstored_control.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/xenstore/xenstored_control.c 
> > b/tools/xenstore/xenstored_control.c
> > index 7c149117b1..d99b7eb7f9 100644
> > --- a/tools/xenstore/xenstored_control.c
> > +++ b/tools/xenstore/xenstored_control.c
> > @@ -171,6 +171,8 @@ static int do_control_help(void *ctx, struct connection 
> > *conn,
> >     resp[len] = 0;
> >  
> >     send_reply(conn, XS_CONTROL, resp, len);
> > +
> > +   talloc_free(resp);
> 
> Sorry, no. The context for the allocation is "in" which will be freed
> automatically.
> 

You're right. Coverity isn't smart enough to figure that out and I
missed it used the passed in ctx.

Ignore this patch.

Wei.

> 
> Juergen
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel