Re: [Xen-devel] [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Anoob Soman [mailto:anoob.soman@xxxxxxxxxx]
> Sent: 02 March 2017 10:50
> To: netdev@xxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>;
> Anoob Soman <anoob.soman@xxxxxxxxxx>
> Subject: [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash
> 
> Allocation of new_hash, inside xenvif_new_hash(), always happen
> in softirq context, so use GFP_ATOMIC instead of GFP_KERNEL for new
> hash allocation.
> 
> Signed-off-by: Anoob Soman <anoob.soman@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  drivers/net/xen-netback/hash.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/hash.c b/drivers/net/xen-
> netback/hash.c
> index e8c5ddd..3c4c58b 100644
> --- a/drivers/net/xen-netback/hash.c
> +++ b/drivers/net/xen-netback/hash.c
> @@ -39,7 +39,7 @@ static void xenvif_add_hash(struct xenvif *vif, const u8
> *tag,
>       unsigned long flags;
>       bool found;
> 
> -     new = kmalloc(sizeof(*entry), GFP_KERNEL);
> +     new = kmalloc(sizeof(*entry), GFP_ATOMIC);
>       if (!new)
>               return;
> 
> --
> 2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel