Re: [Xen-devel] [RFC PATCH v1 12/21] ARM: NUMA: Do not expose numa info to DOM0

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Tue, Feb 21, 2017 at 12:06 AM, Julien Grall <julien.grall@xxxxxxx> wrote:
> Hello Vijay,
>
> On 09/02/17 15:57, vijay.kilari@xxxxxxxxx wrote:
>>
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
>>
>> Delete numa-node-id and distance map from Dom0 DT
>> so that NUMA information is not exposed to Dom0.
>>
>> This helps particularly to boot Node 1 devices
>> as if booting on Node0.
>>
>> However this approach has limitation where memory allocation
>> for the devices should be local.
>
>
> We had a discussion about this few weeks ago but you never answered back...
> (see [1]).

OK. I will reply to [1].

>
> If there is an issue, please provides input with examples and what will
> happen.
>
>
>>
>> Signed-off-by: Vijaya Kumar <Vijaya.Kumar@xxxxxxxxxx>
>> ---
>>  xen/arch/arm/domain_build.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index c97a1f5..5e89eaa 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -424,6 +424,10 @@ static int write_properties(struct domain *d, struct
>> kernel_info *kinfo,
>>              }
>>          }
>>
>> +        /* Don't expose the property numa to the guest */
>> +        if ( dt_property_name_is_equal(prop, "numa-node-id") )
>> +            continue;
>> +
>>          /* Don't expose the property "xen,passthrough" to the guest */
>>          if ( dt_property_name_is_equal(prop, "xen,passthrough") )
>>              continue;
>> @@ -1176,6 +1180,11 @@ static int handle_node(struct domain *d, struct
>> kernel_info *kinfo,
>>          DT_MATCH_TYPE("memory"),
>>          /* The memory mapped timer is not supported by Xen. */
>>          DT_MATCH_COMPATIBLE("arm,armv7-timer-mem"),
>> +        /*
>> +         * NUMA info is not exposed to Dom0.
>> +         * So, skip distance-map infomation
>> +         */
>> +        DT_MATCH_COMPATIBLE("numa-distance-map-v1"),
>>          { /* sentinel */ },
>>      };
>>      static const struct dt_device_match timer_matches[] __initconst =
>>
>
> Regards,
>
> [1]
> https://lists.xenproject.org/archives/html/xen-devel/2016-12/msg02073.html
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel