Re: [Xen-devel] [PATCH 7/7] x86/pagewalk: Re-implement the pagetable walker

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.03.17 at 13:00, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 02/03/17 11:52, Jan Beulich wrote:
>>>>> On 27.02.17 at 15:03, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> @@ -91,12 +91,12 @@ unsigned long hap_p2m_ga_to_gfn(GUEST_PAGING_LEVELS)(
>>>  #if GUEST_PAGING_LEVELS == 3
>>>      top_map += (cr3 & ~(PAGE_MASK | 31));
>>>  #endif
>>> -    missing = guest_walk_tables(v, p2m, ga, &gw, pfec[0], top_mfn, 
>>> top_map);
>>> +    walk_ok = guest_walk_tables(v, p2m, ga, &gw, pfec[0], top_mfn, 
>>> top_map);
>> Since afaict pfec doesn't really point to an array, could I talk you into
>> adjusting the uses you touch anyway to become *pfec?
> 
> I did find the use of an array annoying, but left it as-was.
> 
> Any objection if I do a general cleanup of that as a prerequisite patch,
> to avoid introducing semi-unrelated changes into this patch?

Certainly not.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel