Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.03.17 at 15:58, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 03/02/2017 08:08 AM, Jan Beulich wrote:
>> start_svm() already runs after cpu_data[] was set up, so it shouldn't
>> modify it anymore (at least not directly). Constify the involved
>> pointers.
>>
>> Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86:
>> Fail CPU bringup cleanly if it cannot initialise HVM"), as Andrew
>> Cooper has pointed out: c couldn't possibly equal &boot_cpu_data
>> anymore.
> 
> I can't find Andrew's email --- why is this not possible?

Oh, that was in a private irc chat. The issue is that prior to cited
commit, &boot_cpu_data would have come into the function. The
change done results in the check effectively having become

        &cpu_data[0] == &boot_cpu_data

which is never true.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel