Re: [Xen-devel] [PATCH RFC 1/5] xen: move round_pg{up, down} to pfn.h

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 03, 2017 at 03:05:05AM -0700, Jan Beulich wrote:
> >>> On 03.03.17 at 10:41, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/xen/include/xen/pfn.h
> > +++ b/xen/include/xen/pfn.h
> > @@ -6,4 +6,7 @@
> >  #define PFN_DOWN(x)   ((x) >> PAGE_SHIFT)
> >  #define PFN_UP(x)     (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
> >  
> > +#define round_pgup(_p)    (((_p)+(PAGE_SIZE-1))&PAGE_MASK)
> > +#define round_pgdown(_p)  ((_p)&PAGE_MASK)
> 
> With blanks around binary operators added and leading underscores
> removed I think this could go in right away, i.e.
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Right. Thanks. I will commit the following hunk with your reviewed-by.

#define round_pgup(p)    (((p) + (PAGE_SIZE - 1)) & PAGE_MASK)
#define round_pgdown(p)  ((p) & PAGE_MASK)

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel