[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 01/11] xen/arm: vpl011: Add pl011 uart emulation in Xen



Hi Konrad,

On 03/03/2017 07:59 PM, Konrad Rzeszutek Wilk wrote:
+    rc = alloc_unbound_xen_event_channel(d, 0, current->domain->domain_id,
+                                                        vpl011_notification);
+    if (rc < 0)

Spaces.
+    {
+        printk ("Failed to allocate vpl011 event channel\n");

gdprintk

gdprintk will print the wrong domain as we are allocating a new domain. In general g*printk should be limited to the code we are sure the domain in parameter is the current one.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.