Re: [Xen-devel] [PATCH v2] xen: Allow a default compiled-in command line using Kconfig

[Julien Grall <julien.grall@xxxxxxx>]

Hello,

On 06/03/17 11:01, Zhongze Liu wrote:
> Added 3 new config entries in common/Kconfig:
>     CMDLINE_BOOL, CMDLINE and CMDLINE_OVERRIDE
>
> These 3 entries enable an embedded command line
> to be compiled in the hypervisor.
>
> If CMDLINE_BOOL is set to y, both arm and x86 startup routines
> will combine the compiled-in command line and the boot loader command line
> together to form a complete command line before calling cmdline_parse().
> And if CMDLINE_OVERRIDE is set to y, boot loader command line
> will be ignored.
This behavior seems a little odd to me. Why would you want to append the 
two command line? And more importantly if the same option is passed 
twice, how will this behave?
For example the compile command line could contain iommu=off, but the 
bootloader is passing iommu=on. What would be the final state of the IOMMU?
This one is quite simple, but you could have options which set flags. So 
if you want to override it, the new option would have to unset it.
> This allows downstreams to set their defaults
> without modifying the source code all over the place.
> Also probably useful for the embedded space.
>
> See Also: 
> https://xenproject.atlassian.net/projects/XEN/issues/XEN-41?filter=allopenissues
A shorter link is https://xenproject.atlassian.net/browse/XEN-41

> Signed-off-by: Zhongze Liu <blackskygg@xxxxxxxxx>
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel