Re: [Xen-devel] [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

> +struct xen_9pfs_header {
> +     uint32_t size;
> +     uint8_t id;
> +     uint16_t tag;

I realize that this is in the spec now and it's probably too late to ask
this question but wouldn't it be better if id and tag were swapped? No
need to pack and potentially faster access to tag.

-boris

> +} __attribute__((packed));
> +
> +#define XEN_9PFS_RING_ORDER 6
> +#define XEN_9PFS_RING_SIZE  XEN_FLEX_RING_SIZE(XEN_9PFS_RING_ORDER)
> +DEFINE_XEN_FLEX_RING_AND_INTF(xen_9pfs);
> +
> +#endif


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel