[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t
- To: Johannes Thumshirn <jthumshirn@xxxxxxx>, Chris Leech <cleech@xxxxxxxxxx>
- From: "Reshetova, Elena" <elena.reshetova@xxxxxxxxx>
- Date: Thu, 9 Mar 2017 09:26:03 +0000
- Accept-language: en-US
- Cc: "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "target-devel@xxxxxxxxxxxxxxx" <target-devel@xxxxxxxxxxxxxxx>, "linux1394-devel@xxxxxxxxxxxxxxxxxxxxx" <linux1394-devel@xxxxxxxxxxxxxxxxxxxxx>, "devel@xxxxxxxxxxxxxxxxxxxx" <devel@xxxxxxxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "linux-serial@xxxxxxxxxxxxxxx" <linux-serial@xxxxxxxxxxxxxxx>, "fcoe-devel@xxxxxxxxxxxxx" <fcoe-devel@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "open-iscsi@xxxxxxxxxxxxxxxx" <open-iscsi@xxxxxxxxxxxxxxxx>, "linux-media@xxxxxxxxxxxxxxx" <linux-media@xxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "linux-raid@xxxxxxxxxxxxxxx" <linux-raid@xxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx" <linux-bcache@xxxxxxxxxxxxxxx>, Hans Liljestrand <ishkamiel@xxxxxxxxx>, David Windsor <dwindsor@xxxxxxxxx>, "gregkh@xxxxxxxxxxxxxxxxxxx" <gregkh@xxxxxxxxxxxxxxxxxxx>, "linux-usb@xxxxxxxxxxxxxxx" <linux-usb@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "devel@xxxxxxxxxxxxxxxxxxxxxx" <devel@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 09 Mar 2017 09:26:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
- Thread-index: AQHSloVF8C0x1d8w/kWsokOB0ZCdnKGLS+IAgADRouCAABfQAIAAC5/w
- Thread-topic: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t
> On 03/09/2017 08:18 AM, Reshetova, Elena wrote:
> >> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote:
> >>> refcount_t type and corresponding API should be
> >>> used instead of atomic_t when the variable is used as
> >>> a reference counter. This allows to avoid accidental
> >>> refcounter overflows that might lead to use-after-free
> >>> situations.
> >>>
> >>> Signed-off-by: Elena Reshetova <elena.reshetova@xxxxxxxxx>
> >>> Signed-off-by: Hans Liljestrand <ishkamiel@xxxxxxxxx>
> >>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >>> Signed-off-by: David Windsor <dwindsor@xxxxxxxxx>
> >>
> >> This looks OK to me.
> >>
> >> Acked-by: Chris Leech <cleech@xxxxxxxxxx>
> >
> > Thank you for review! Do you have a tree that can take this change?
>
> Hi Elena,
>
> iscsi like fcoe should go via the SCSI tree.
Thanks Johannes! Should I resend with "Acked-by" added in order for it to be
picked up?
Best Regards,
Elena.
>
> Byte,
> Johannes
>
> --
> Johannes Thumshirn Storage
> jthumshirn@xxxxxxx +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
