Re: [Xen-devel] [Qemu-devel] [PATCH] xen: don't save/restore the physmap on VM save/restore

[no-reply@xxxxxxxxxxx]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH] xen: don't save/restore the physmap on VM 
save/restore
Message-id: 1489084689-19008-1-git-send-email-igor.druzhinin@xxxxxxxxxx

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1489084689-19008-1-git-send-email-igor.druzhinin@xxxxxxxxxx -> 
patchew/1489084689-19008-1-git-send-email-igor.druzhinin@xxxxxxxxxx
Switched to a new branch 'test'
ebd2fd8 xen: don't save/restore the physmap on VM save/restore

=== OUTPUT BEGIN ===
Checking PATCH 1/1: xen: don't save/restore the physmap on VM save/restore...
ERROR: space prohibited between function name and open parenthesis '('
#105: FILE: xen-hvm.c:344:
+    physmap = g_malloc(sizeof (XenPhysmap));

ERROR: that open brace { should be on the previous line
#114: FILE: xen-hvm.c:353:
+    if (runstate_check(RUN_STATE_INMIGRATE))
+    {

ERROR: trailing whitespace
#117: FILE: xen-hvm.c:356:
+         * established during the restore phase so we can safely update the $

ERROR: braces {} are necessary for all arms of this statement
#119: FILE: xen-hvm.c:358:
+         if (mr == framebuffer)
[...]

total: 4 errors, 0 warnings, 196 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel