Re: [Xen-devel] [PATCH v2 08/17] tools: provide pkg-config file for libxengnttab

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 14, 2017 at 08:06:51PM +0000, Andrew Cooper wrote:
> On 14/03/17 13:31, Juergen Gross wrote:
> > In order to be able to use pkg-config for obtaining linker- and
> > compiler-flags provide a xengnttab.pc and a xengntshr.pc file.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> What is xengntshr.pc actually for?
> 
> (I am forward porting the XenServer patch queue, and rpm informs me that
> there is no real libxengntshr)
> 
> All gntshr functionality is inside gnttab, and only a single shared
> object exists.
> 
> In fact, I can't see why we have any *_libxengntshr infrastructure at
> all (c/s a71ad0feada which introduced it originally doesn't help; they
> weren't two libraries before either...).
> 
> The two uses of *_libxengntshr infrastructure are libxc and libvchan,
> both of which reference *_libxengnttab immediately before.
> 

I don't know why they are arranged like that.

But I suppose we should keep the distinction so that people who link
against gntshr won't need to change their build rune.

Wei.

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel